[SPARK-25425][SQL][BACKPORT-2.3] Extra options should override session options in DataSource V2 #22489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataSource V2
In the PR, I propose overriding session options by extra options in DataSource V2. Extra options are more specific and set via `.option()`, and should overwrite more generic session options. Entries from seconds map overwrites entries with the same key from the first map, for example:
```Scala
scala> Map("option" -> false) ++ Map("option" -> true)
res0: scala.collection.immutable.Map[String,Boolean] = Map(option -> true)
```
Added a test for checking which option is propagated to a data source in `load()`.
Closes apache#22413 from MaxGekk/session-options.
Lead-authored-by: Maxim Gekk <[email protected]>
Co-authored-by: Dongjoon Hyun <[email protected]>
Co-authored-by: Maxim Gekk <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
@dongjoon-hyun Please, take a look at this PR. This is the backport of #22413 to Spark 2.3. |
|
Test build #96341 has finished for PR 22489 at commit
|
Member
Author
|
@dongjoon-hyun @gatorsmile Can the fix be included into the upcoming minor release of 2.3? |
Member
|
I've considered this for 2.3.3 since 2.3.2 RC6 vote was already started. For now, I'm waiting for the result of vote. |
Member
|
Retest this please. |
|
Test build #96592 has finished for PR 22489 at commit
|
| } | ||
|
|
||
| override def createReader(options: DataSourceOptions): DataSourceReader = new Reader | ||
| case class SimpleDataSourceV2Reader(options: DataSourceOptions) extends DataSourceReader { |
Member
There was a problem hiding this comment.
Thank you for this non-trivial backporting, @MaxGekk !
Member
|
+1, LGTM. Merged to |
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2018
…n options in DataSource V2 ## What changes were proposed in this pull request? In the PR, I propose overriding session options by extra options in DataSource V2. Extra options are more specific and set via `.option()`, and should overwrite more generic session options. ## How was this patch tested? Added tests for read and write paths. Closes #22489 from MaxGekk/session-options-2.3. Authored-by: Maxim Gekk <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Thank you, @MaxGekk . Since this lands on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose overriding session options by extra options in DataSource V2. Extra options are more specific and set via
.option(), and should overwrite more generic session options.How was this patch tested?
Added tests for read and write paths.