Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Sep 20, 2018

What changes were proposed in this pull request?

This goes to revert sequential PRs based on some discussion and comments at #16677 (comment).

#22344
#22330
#22239
#16677

How was this patch tested?

Existing tests.

…mber is bigger than topKSortFallbackThreshold"

This reverts commit 2f42239.
…ion on TakeOrderedAndProjectSuite finishes"

This reverts commit 3aa6028.
@viirya
Copy link
Member Author

viirya commented Sep 20, 2018

cc @cloud-fan

@cloud-fan
Copy link
Contributor

LGTM, thanks!

@SparkQA
Copy link

SparkQA commented Sep 20, 2018

Test build #96320 has finished for PR 22481 at commit 4532aaa.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait BaseLimitExec extends UnaryExecNode with CodegenSupport
  • case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec
  • case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec

@dilipbiswal
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Sep 20, 2018

Test build #96332 has finished for PR 22481 at commit 4532aaa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait BaseLimitExec extends UnaryExecNode with CodegenSupport
  • case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec
  • case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec

@cloud-fan
Copy link
Contributor

thanks, merging to master/2.4!

asfgit pushed a commit that referenced this pull request Sep 20, 2018
## What changes were proposed in this pull request?

This goes to revert sequential PRs based on some discussion and comments at #16677 (comment).

#22344
#22330
#22239
#16677

## How was this patch tested?

Existing tests.

Closes #22481 from viirya/revert-SPARK-19355-1.

Authored-by: Liang-Chi Hsieh <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit 89671a2)
Signed-off-by: Wenchen Fan <[email protected]>
@asfgit asfgit closed this in 89671a2 Sep 20, 2018
@viirya viirya deleted the revert-SPARK-19355-1 branch December 27, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants