Skip to content

[SPARK-3372] [MLlib] MLlib doesn't pass maven build / checkstyle due to multi-byte character contained in Gradient.scala #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-3372] [MLlib] MLlib doesn't pass maven build / checkstyle due to multi-byte character contained in Gradient.scala #2248

wants to merge 1 commit into from

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Sep 3, 2014

No description provided.

@sarutak sarutak changed the title [SPARK-3372] [MLLIB] Scalastyle fails due to UTF-8 character being contained in Gradient.scala [SPARK-3372] [MLLIB] Scalastyle fails due to UTF-8 character contained in Gradient.scala Sep 3, 2014
@SparkQA
Copy link

SparkQA commented Sep 3, 2014

QA tests have started for PR 2248 at commit 73a28b8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 3, 2014

QA tests have finished for PR 2248 at commit 73a28b8.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak sarutak changed the title [SPARK-3372] [MLLIB] Scalastyle fails due to UTF-8 character contained in Gradient.scala [SPARK-3372] [MLlib] Scalastyle fails due to UTF-8 character contained in Gradient.scala Sep 3, 2014
@sarutak sarutak changed the title [SPARK-3372] [MLlib] Scalastyle fails due to UTF-8 character contained in Gradient.scala [SPARK-3372] [MLlib] MLlib doesn't pass maven build / checkstyle due to multi-byte character contained in Gradient.scala Sep 4, 2014
asfgit pushed a commit that referenced this pull request Sep 4, 2014
@sarutak @mengxr
[SPARK-3372] [MLlib] MLlib doesn't pass maven build / checkstyle due …
f41c45a 
…to multi-byte character contained in Gradient.scala

Author: Kousuke Saruta <[email protected]>

Closes #2248 from sarutak/SPARK-3372 and squashes the following commits:

73a28b8 [Kousuke Saruta] Replaced UTF-8 hyphen with ascii hyphen

(cherry picked from commit 1bed0a3)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 1bed0a3 Sep 4, 2014
@mengxr
Copy link
Contributor

mengxr commented Sep 4, 2014

@sarutak Nice catch! I'm merging this into master and branch-1.1. Thanks!

Btw, maven scalastyle doesn't fail on my machine (OSX). Which OS are you using?

@sarutak
Copy link
Member Author

sarutak commented Sep 4, 2014

@mengxr Thank you for picking up this PR.
My colleague tried to build on Windows8 with "mvn package" and then failed to build.

@sarutak sarutak deleted the SPARK-3372 branch April 11, 2015 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarutak @SparkQA @mengxr