[SPARK-25404][SQL] Staging path may not on the expected place when table path contains the stagingDir string #22412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble path contains the stagingDir string ## What changes were proposed in this pull request? Fix Staging path. ## How was this patch tested? Manual test.
| val inputPathUri: URI = inputPath.toUri | ||
| val inputPathName: String = inputPathUri.getPath | ||
| val fs: FileSystem = inputPath.getFileSystem(hadoopConf) | ||
| var stagingPathName: String = |
Member
There was a problem hiding this comment.
This code is introduced form #12770, do you check the relative UT? Maybe UT relating with SessionState and DDLSuite.
Contributor
Author
There was a problem hiding this comment.
Yes, I had checked the pr #12770 too. But I'm not very clear why we should do like that.
|
Can one of the admins verify this patch? |
|
We're closing this PR because it hasn't been updated in a while. If you'd like to revive this PR, please reopen it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As described in #SPARK-25404, staging path may not on the right place we expect. I'm not quiet sure in which case the
inputPathNamecontains thestagingDir, but it seemsnew Path(inputPathName, stagingDir).toStringis enough.How was this patch tested?
Manually test with debug mode, and check the staging files on right path.