Skip to content

Conversation

@tdas
Copy link
Contributor

@tdas tdas commented Sep 2, 2014

  • Include kinesis in the unidocs
  • Hide non-public classes from docs

@SparkQA
Copy link

SparkQA commented Sep 2, 2014

QA tests have started for PR 2239 at commit e9a6c01.

  • This patch merges cleanly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the one below should also have :: Experimental :: in the doc signature. For now we do both.

@pwendell
Copy link
Contributor

pwendell commented Sep 2, 2014

Minor comment but LGTM otherwise.

@SparkQA
Copy link

SparkQA commented Sep 2, 2014

QA tests have finished for PR 2239 at commit e9a6c01.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final class JavaKinesisWordCountASL

@tdas
Copy link
Contributor Author

tdas commented Sep 2, 2014

@pwendell Addressed your comment. Should I merge this to master and branch-1.1?

@pwendell
Copy link
Contributor

pwendell commented Sep 3, 2014

Yeah go for it - thanks TD

@asfgit asfgit closed this in e9bb12b Sep 3, 2014
asfgit pushed a commit that referenced this pull request Sep 3, 2014
- Include kinesis in the unidocs
- Hide non-public classes from docs

Author: Tathagata Das <[email protected]>

Closes #2239 from tdas/kinesis-doc-fix and squashes the following commits:

156e20c [Tathagata Das] More fixes, based on PR comments.
e9a6c01 [Tathagata Das] Fixed docs related to kinesis

(cherry picked from commit e9bb12b)
Signed-off-by: Tathagata Das <[email protected]>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
- Include kinesis in the unidocs
- Hide non-public classes from docs

Author: Tathagata Das <[email protected]>

Closes apache#2239 from tdas/kinesis-doc-fix and squashes the following commits:

156e20c [Tathagata Das] More fixes, based on PR comments.
e9a6c01 [Tathagata Das] Fixed docs related to kinesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants