[SPARK-22357][CORE][FOLLOWUP] SparkContext.binaryFiles ignore minPartitions parameter #22356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
imatiach-msft
approved these changes
Sep 6, 2018
| StandardCharsets.UTF_8) | ||
| } | ||
|
|
||
| assert(sc.binaryFiles(tempDirPath, minPartitions = 1).getNumPartitions === 1) |
Contributor
There was a problem hiding this comment.
nitpick: maybe put these three asserts in a loop
|
|
||
| test("SPARK-22357 test binaryFiles minPartitions") { | ||
| sc = new SparkContext(new SparkConf().setAppName("test").setMaster("local") | ||
| .set("spark.files.openCostInBytes", "0") |
Contributor
There was a problem hiding this comment.
why is this setting needed: spark.files.openCostInBytes
Member
Author
There was a problem hiding this comment.
This removes its effect in the section of code we're really trying to test:
def setMinPartitions(sc: SparkContext, context: JobContext, minPartitions: Int) {
val defaultMaxSplitBytes = sc.getConf.get(config.FILES_MAX_PARTITION_BYTES)
val openCostInBytes = sc.getConf.get(config.FILES_OPEN_COST_IN_BYTES)
val defaultParallelism = Math.max(sc.defaultParallelism, minPartitions)
val files = listStatus(context).asScala
val totalBytes = files.filterNot(_.isDirectory).map(_.getLen + openCostInBytes).sum
val bytesPerCore = totalBytes / defaultParallelism
val maxSplitSize = Math.min(defaultMaxSplitBytes, Math.max(openCostInBytes, bytesPerCore))
super.setMaxSplitSize(maxSplitSize)
}
Contributor
There was a problem hiding this comment.
ah, I see, thanks for pointing that out!
|
Test build #95769 has finished for PR 22356 at commit
|
|
Test build #95771 has finished for PR 22356 at commit
|
Contributor
|
Thanks for taking my codes. Looks good. |
HyukjinKwon
approved these changes
Sep 6, 2018
Member
Author
|
Merged to master/2.4 |
asfgit
pushed a commit
that referenced
this pull request
Sep 7, 2018
…itions parameter ## What changes were proposed in this pull request? This adds a test following #21638 ## How was this patch tested? Existing tests and new test. Closes #22356 from srowen/SPARK-22357.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 4e3365b) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds a test following #21638
How was this patch tested?
Existing tests and new test.