Skip to content

[SPARK-21786][SQL][FOLLOWUP] Add compressionCodec test for CTAS #22302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −6
Closed

[SPARK-21786][SQL][FOLLOWUP] Add compressionCodec test for CTAS #22302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class CompressionCodecSuite extends TestHiveSingleton with ParquetTest with Befo
""".stripMargin)
}

private def writeDateToTableUsingCTAS(
private def writeDataToTableUsingCTAS(
rootDir: File,
tableName: String,
partitionValue: Option[String],
Expand Down Expand Up @@ -152,7 +152,7 @@ class CompressionCodecSuite extends TestHiveSingleton with ParquetTest with Befo
usingCTAS: Boolean): String = {
val partitionValue = if (isPartitioned) Some("test") else None
if (usingCTAS) {
writeDateToTableUsingCTAS(tmpDir, tableName, partitionValue, format, compressionCodec)
writeDataToTableUsingCTAS(tmpDir, tableName, partitionValue, format, compressionCodec)
} else {
createTable(tmpDir, tableName, isPartitioned, format, compressionCodec)
writeDataToTable(tableName, partitionValue)
Expand Down Expand Up @@ -258,8 +258,7 @@ class CompressionCodecSuite extends TestHiveSingleton with ParquetTest with Befo
def checkForTableWithCompressProp(format: String, compressCodecs: List[String]): Unit = {
Seq(true, false).foreach { isPartitioned =>
Seq(true, false).foreach { convertMetastore =>
// TODO: Also verify CTAS(usingCTAS=true) cases when the bug(SPARK-22926) is fixed.
Seq(false).foreach { usingCTAS =>
Seq(true, false).foreach { usingCTAS =>
checkTableCompressionCodecForCodecs(
format,
isPartitioned,
Expand All @@ -281,8 +280,7 @@ class CompressionCodecSuite extends TestHiveSingleton with ParquetTest with Befo
def checkForTableWithoutCompressProp(format: String, compressCodecs: List[String]): Unit = {
Seq(true, false).foreach { isPartitioned =>
Seq(true, false).foreach { convertMetastore =>
// TODO: Also verify CTAS(usingCTAS=true) cases when the bug(SPARK-22926) is fixed.
Seq(false).foreach { usingCTAS =>
Seq(true, false).foreach { usingCTAS =>
checkTableCompressionCodecForCodecs(
format,
isPartitioned,
Expand Down