Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

SPARK-25144 reports memory leaks on Apache Spark 2.0.2 ~ 2.3.2-RC5. The bug is already fixed via #21738 as a part of SPARK-21743. This PR only adds a test case to prevent any future regression.

scala> case class Foo(bar: Option[String])
scala> val ds = List(Foo(Some("bar"))).toDS
scala> val result = ds.flatMap(_.bar).distinct
scala> result.rdd.isEmpty
18/08/19 23:01:54 WARN Executor: Managed memory leak detected; size = 8650752 bytes, TID = 125
res0: Boolean = false

How was this patch tested?

Pass the Jenkins with a new added test case.

@dongjoon-hyun
Copy link
Member Author

cc @HyukjinKwon

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @HyukjinKwon .

@SparkQA
Copy link

SparkQA commented Aug 20, 2018

Test build #94962 has finished for PR 22155 at commit 27497f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class Foo(bar: Option[String])

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in 883f3af Aug 21, 2018
@dongjoon-hyun
Copy link
Member Author

Thank you!

@dongjoon-hyun dongjoon-hyun deleted the SPARK-25144-2 branch August 21, 2018 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants