[SPARK-25068][SQL] Add exists function. #22052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #94483 has finished for PR 22052 at commit
|
cloud-fan
reviewed
Aug 9, 2018
| while (i < arr.numElements) { | ||
| elementVar.value.set(arr.get(i, elementVar.dataType)) | ||
| if (f.eval(inputRow).asInstanceOf[Boolean]) { | ||
| return true |
Contributor
There was a problem hiding this comment.
shall we use a var exists = false to keep the result, and stop the loop when result is true while (i < arr.numElements & !exists)?
IIUC return in Scala is implemented by throwing an exception, which may have performance issue.
Contributor
|
LGTM |
|
Test build #94510 has finished for PR 22052 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr adds
existsfunction which tests whether a predicate holds for one or more elements in the array.How was this patch tested?
Added tests.