[SPARK-24987][SS] - Fix Kafka consumer leak when no new offsets for TopicPartition #21983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This small fix adds a
consumer.release()call toKafkaSourceRDDin the case where we've retrieved offsets from Kafka, but thefromOffsetis equal to thelastOffset, meaning there is no new data to read for a particular topic partition. Up until now, we'd just return an empty iterator without closing the consumer which would cause a FD leak.If accepted, this pull request should be merged into master as well.
How was this patch tested?
Haven't ran any specific tests, would love help on how to test methods running inside
RDD.compute.