Spark 20597 #21961
Closed
Spark 20597 #21961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Satyajitv, thanks! I am a bot who has found some folks who might be able to help with the review:@tdas, @zsxwing and @cloud-fan |
|
Can one of the admins verify this patch? |
|
Hello @Satyajitv, please rename the title of this PR properly. |
srowen
reviewed
Aug 17, 2018
| val defaultTopic = parameters.get(TOPIC_OPTION_KEY).map(_.trim) | ||
| // Picks the defaulttopicname from "path" key, an entry in "parameters" Map, | ||
| // if no topic key is present in the "parameters" Map and is provided with key "path". | ||
| val defaultTopic = parameters.get(TOPIC_OPTION_KEY) match { |
Member
There was a problem hiding this comment.
Isn't this simpler as something like
val defaultTopic = parameters.getOrElse(TOPIC_OPTION_KEY, parameters.get(PATH_OPTION_KEY)).map(_.trim)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Default topic first checks if TOPIC_OPTION_KEY is provided,
if TOPIC_OPTION_KEY is provided then
defaulttopic=TOPIC_OPTION_KEY
else TOPIC_OPTION_KEY is not provided then
defaulttopic=PATH_OPTION_KEY
How was this patch tested?
Have tested the code in local, but would start writing tests once the approach is confirmed by @jaceklaskowski, as I am expecting change requests.
PF more details on https://issues.apache.org/jira/browse/SPARK-20597
Please review http://spark.apache.org/contributing.html before opening a pull request.