Skip to content

[SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "provided" #21879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "provided" #21879

wants to merge 1 commit into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Jul 26, 2018 •
edited
Loading

What changes were proposed in this pull request?

Please see SPARK-24927 for more details.

How was this patch tested?

Manually tested.

@liancheng liancheng changed the title [SPARK-24927] The scope of snappy-java cannot be "provided" [SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "provided" Jul 26, 2018
@SparkQA
Copy link

SparkQA commented Jul 26, 2018

Test build #93585 has finished for PR 21879 at commit 93c34da.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented Jul 26, 2018

retest this please

@liancheng
Copy link
Contributor Author

liancheng commented Jul 26, 2018

The Kafka DStream test failures seem to be flaky and irrelevant.

@SparkQA
Copy link

SparkQA commented Jul 26, 2018

Test build #93609 has finished for PR 21879 at commit 93c34da.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

liancheng commented Jul 26, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jul 27, 2018

Test build #93640 has finished for PR 21879 at commit 93c34da.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

liancheng commented Jul 27, 2018

retest this please

@cloud-fan
Copy link
Contributor

cloud-fan commented Jul 27, 2018

LGTM, how far shall we backport this patch?

@jiangxb1987
Copy link
Contributor

jiangxb1987 commented Jul 27, 2018

LGTM

@liancheng
Copy link
Contributor Author

liancheng commented Jul 27, 2018

@cloud-fan Didn't try to actually reproduce this issue in branches other than branch-2.3, but just by checking the POM files, this issue existed ever since at least 1.6.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 27, 2018

Seems right to me too.

@gatorsmile
Copy link
Member

gatorsmile commented Jul 27, 2018

Let us backport it to 2.2 and 2.3.

@SparkQA
Copy link

SparkQA commented Jul 27, 2018

Test build #93655 has finished for PR 21879 at commit 93c34da.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented Jul 27, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jul 27, 2018

Test build #93660 has finished for PR 21879 at commit 93c34da.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jul 27, 2018
@liancheng @gatorsmile
[SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "…
d5f340f 
…provided"

## What changes were proposed in this pull request?

Please see [SPARK-24927][1] for more details.

[1]: https://issues.apache.org/jira/browse/SPARK-24927

## How was this patch tested?

Manually tested.

Author: Cheng Lian <[email protected]>

Closes #21879 from liancheng/spark-24927.
asfgit pushed a commit that referenced this pull request Jul 27, 2018
@liancheng @gatorsmile
[SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "…
7376473 
…provided"

## What changes were proposed in this pull request?

Please see [SPARK-24927][1] for more details.

[1]: https://issues.apache.org/jira/browse/SPARK-24927

## How was this patch tested?

Manually tested.

Author: Cheng Lian <[email protected]>

Closes #21879 from liancheng/spark-24927.

(cherry picked from commit d5f340f)
Signed-off-by: Xiao Li <[email protected]>
@gatorsmile
Copy link
Member

gatorsmile commented Jul 27, 2018

Thanks! Merged to master/2.3/2.2

@asfgit asfgit closed this in c9bec1d Jul 27, 2018
Willymontaz pushed a commit to criteo-forks/spark that referenced this pull request Sep 26, 2019
@liancheng
[SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "…
ddb8a43 
…provided"

## What changes were proposed in this pull request?

Please see [SPARK-24927][1] for more details.

[1]: https://issues.apache.org/jira/browse/SPARK-24927

## How was this patch tested?

Manually tested.

Author: Cheng Lian <[email protected]>

Closes apache#21879 from liancheng/spark-24927.

(cherry picked from commit d5f340f)
Signed-off-by: Xiao Li <[email protected]>
Willymontaz pushed a commit to criteo-forks/spark that referenced this pull request Sep 27, 2019
@liancheng @Willymontaz
[SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "…
8499feb 
…provided"

## What changes were proposed in this pull request?

Please see [SPARK-24927][1] for more details.

[1]: https://issues.apache.org/jira/browse/SPARK-24927

## How was this patch tested?

Manually tested.

Author: Cheng Lian <[email protected]>

Closes apache#21879 from liancheng/spark-24927.

(cherry picked from commit d5f340f)
Signed-off-by: Xiao Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liancheng @SparkQA @gatorsmile @cloud-fan @jiangxb1987 @HyukjinKwon