Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Jul 18, 2018

What changes were proposed in this pull request?

Fix regexes in spark-sql command examples.
This takes over #18477

How was this patch tested?

Existing tests. I verified the existing example doesn't work in spark-sql, but new ones does.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jul 18, 2018

Test build #93241 has finished for PR 21808 at commit a444e80.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@srowen
Copy link
Member Author

srowen commented Jul 18, 2018

Merged to master

@asfgit asfgit closed this in 753f115 Jul 18, 2018
@srowen srowen deleted the SPARK-21261 branch August 4, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants