[SPARK-24852][ML] Update spark.ml to use Instrumentation.instrumented.

[MrBago]

What changes were proposed in this pull request?

Followup for #21719.
Update spark.ml training code to fully wrap instrumented methods and remove old instrumentation APIs.

How was this patch tested?

existing tests.

Please review http://spark.apache.org/contributing.html before opening a pull request.

[SparkQA]

Test build #93207 has finished for PR 21799 at commit e43491c.

• This patch fails to build.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #93238 has finished for PR 21799 at commit 5ce5dd1.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[jkbradley]

This LGTM except for 1 suggestion:
We could make the Instrumentation constructor private like this:

private[spark] class Instrumentation private () extends Logging {

That would force developers to go through the instrumented code path.

[SparkQA]

Test build #93254 has finished for PR 21799 at commit dddccf6.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[jkbradley]

LGTM
Merging with master
Thanks @MrBago !