[SPARK-24673][SQL][PYTHON][FOLLOWUP] Support Column arguments in timezone of from_utc_timestamp/to_utc_timestamp #21723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
HyukjinKwon
reviewed
Jul 6, 2018
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Seems from_utc_timestamp is missed.
python/pyspark/sql/functions.py
Outdated
| return Column(sc._jvm.functions.to_utc_timestamp(_to_java_column(timestamp), tz)) | ||
|
|
||
| if isinstance(tz, Column): | ||
| timezone = _to_java_column(tz) |
Member
There was a problem hiding this comment.
@maropu, not a big deal at all but mind tz = _to_java_column(tz) to reduce the diff?
| """ | ||
| Given a timestamp like '2017-07-14 02:40:00.0', interprets it as a time in the given time | ||
| zone, and renders that time as a timestamp in UTC. For example, 'GMT+1' would yield | ||
| '2017-07-14 01:40:00.0'. |
Member
There was a problem hiding this comment.
I have thought about this for long time and let's start to describe what we change within Python side:
:param timestamp: the column that contains timestamps
:param tz: a string that has the ID of timezone, e.g. "GMT", "America/Los_Angeles", etc.
.. versionchanged:: 2.4
`tz` can take a :class:`Column` containing timezone ID strings.
|
Test build #92667 has finished for PR 21723 at commit
|
Member
Author
|
oh, sorry, I'll update soon. |
|
Test build #92677 has finished for PR 21723 at commit
|
Member
|
@maropu, are you online? mind if I ask to fix PR title and description before I merge this one? |
Member
Author
|
ah, ok. I’ll update soon |
maropu
changed the title
Member
Author
|
@HyukjinKwon ok, fixed! |
Member
|
Merged to master. |
Member
|
Thanks, @maropu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr supported column arguments in timezone of
from_utc_timestamp/to_utc_timestamp(follow-up of #21693).How was this patch tested?
Added tests.