[SPARK-23931][SQL][FOLLOW-UP] Make arrays_zip in function.scala @scala.annotation.varargs.
#21630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
LGTM
…On Mon, Jun 25, 2018, 11:16 AM Takuya UESHIN ***@***.***> wrote:
cc @DylanGuedes <https://github.com/DylanGuedes> @HyukjinKwon
<https://github.com/HyukjinKwon> @viirya <https://github.com/viirya>
@mgaido91 <https://github.com/mgaido91>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21630 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEM92Pj4G5R28SPSIZaxSNaHAJ7oGErks5uAFYZgaJpZM4U1c7c>
.
|
|
Test build #92279 has finished for PR 21630 at commit
|
gatorsmile
reviewed
Jun 25, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks! Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up pr of #21045 which added
arrays_zip.The
arrays_zipin functions.scala should've been@scala.annotation.varargs.This pr makes it
@scala.annotation.varargs.How was this patch tested?
Existing tests.