Skip to content

Conversation

@xueyumusic
Copy link
Contributor

What changes were proposed in this pull request?

add three config which are mentioned in the pr #21567 , they are spark.python.task.killTimeout, spark.worker.driverTerminateTimeout and spark.ui.consoleProgress.update.interval

How was this patch tested?

doc build

<td><code>spark.python.task.killTimeout</code></td>
<td>2s</td>
<td>
How long to wait before killing the python worker if a task cannot be interrupted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Timeout to wait before killing the python worker when a task cannot be interrupted."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated and fix confilct, please have a review, thanks, @zsxwing @jiangxb1987

@jiangxb1987
Copy link
Contributor

cc @zsxwing

@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Jul 16, 2018

Test build #93064 has finished for PR 21624 at commit 6886111.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every config property is meant to be exposed to users. The sql ones have documentation in the source code, which leads me to believe they are OK to document publicly. The rest do not; they may be more internal or experimental configs to change. It's not wrong to document them, but it kind of means guaranteeing they will persist. The conservative thing would be to restrict this to the sql properties.

</td>
</tr>
<tr>
<td><code>spark.sql.repl.eagerEval.truncate</code></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spark.sql.* configs should be in sql-programming-guide.md

</td>
</tr>
<tr>
<td><code>spark.worker.driverTerminateTimeout</code></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise spark.worker.* configs are in spark-standalone.md, it appears

@srowen srowen mentioned this pull request Aug 20, 2018
@asfgit asfgit closed this in b8788b3 Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants