-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-24639][DOC] Add three config in the doc #21624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/configuration.md
Outdated
| <td><code>spark.python.task.killTimeout</code></td> | ||
| <td>2s</td> | ||
| <td> | ||
| How long to wait before killing the python worker if a task cannot be interrupted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Timeout to wait before killing the python worker when a task cannot be interrupted."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated and fix confilct, please have a review, thanks, @zsxwing @jiangxb1987
|
cc @zsxwing |
|
ok to test |
|
Test build #93064 has finished for PR 21624 at commit
|
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not every config property is meant to be exposed to users. The sql ones have documentation in the source code, which leads me to believe they are OK to document publicly. The rest do not; they may be more internal or experimental configs to change. It's not wrong to document them, but it kind of means guaranteeing they will persist. The conservative thing would be to restrict this to the sql properties.
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>spark.sql.repl.eagerEval.truncate</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spark.sql.* configs should be in sql-programming-guide.md
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>spark.worker.driverTerminateTimeout</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise spark.worker.* configs are in spark-standalone.md, it appears
What changes were proposed in this pull request?
add three config which are mentioned in the pr #21567 , they are
spark.python.task.killTimeout,spark.worker.driverTerminateTimeoutandspark.ui.consoleProgress.update.intervalHow was this patch tested?
doc build