Skip to content

Conversation

@mgaido91
Copy link
Contributor

What changes were proposed in this pull request?

The PR updates the 2.3 version tested to the new release 2.3.1.

How was this patch tested?

existing UTs

@mgaido91
Copy link
Contributor Author

cc @vanzin

@SparkQA
Copy link

SparkQA commented Jun 12, 2018

Test build #91729 has finished for PR 21543 at commit 08461b4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this seems fragile

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks! Merged to master

@asfgit asfgit closed this in 3bf7691 Jun 13, 2018
@vanzin
Copy link
Contributor

vanzin commented Jun 13, 2018

This should go into branch-2.3 too.

I also think this is a little fragile (which is why I filed SPARK-24532), and I've been playing with some alternative code, but it feels like a bit too much code to avoid a little extra work on every release...

https://github.com/vanzin/spark/tree/SPARK-24532

asfgit pushed a commit that referenced this pull request Jun 15, 2018
The PR updates the 2.3 version tested to the new release 2.3.1.

existing UTs

Author: Marco Gaido <[email protected]>

Closes #21543 from mgaido91/patch-1.

(cherry picked from commit 3bf7691)
Signed-off-by: Marcelo Vanzin <[email protected]>
mccheah pushed a commit to palantir/spark that referenced this pull request Jun 15, 2018
## What changes were proposed in this pull request?

The PR updates the 2.3 version tested to the new release 2.3.1.

## How was this patch tested?

existing UTs

Author: Marco Gaido <[email protected]>

Closes apache#21543 from mgaido91/patch-1.
robert3005 pushed a commit to palantir/spark that referenced this pull request Jun 24, 2018
## What changes were proposed in this pull request?

The PR updates the 2.3 version tested to the new release 2.3.1.

## How was this patch tested?

existing UTs

Author: Marco Gaido <[email protected]>

Closes apache#21543 from mgaido91/patch-1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants