Skip to content

[SPARK-24505][SQL] Convert strings in codegen to blocks: Cast and BoundAttribute #21537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[SPARK-24505][SQL] Convert strings in codegen to blocks: Cast and BoundAttribute #21537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
89d0252
Convert strings in codegen to blocks.
viirya Jun 12, 2018
531faf4
Address comment.
viirya Jun 13, 2018
b592e66
Rename api.
viirya Jun 14, 2018
a972e0e
Improve document.
viirya Jun 15, 2018
4b90551
Address comment.
viirya Jun 21, 2018
ce5aa08
Merge remote-tracking branch 'upstream/master' into SPARK-24505-1
viirya Jul 6, 2018
d278017
Merge remote-tracking branch 'upstream/master' into SPARK-24505-1
viirya Jul 16, 2018
7b0ee94
Update comment.
viirya Jul 16, 2018
f1f2180
Address comment.
viirya Jul 16, 2018
807d8d4
Address comment.
viirya Jul 16, 2018
508e091
Address comment.
viirya Aug 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ package org.apache.spark.sql.catalyst.expressions
import org.apache.spark.internal.Logging
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.errors.attachTree
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, CodeGenerator, ExprCode, FalseLiteral}
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, CodeGenerator, ExprCode, FalseLiteral, JavaCode}
import org.apache.spark.sql.catalyst.expressions.codegen.Block._
import org.apache.spark.sql.types._

Expand Down Expand Up @@ -53,7 +53,7 @@ case class BoundReference(ordinal: Int, dataType: DataType, nullable: Boolean)
ev.copy(code = oev.code)
} else {
assert(ctx.INPUT_ROW != null, "INPUT_ROW and currentVars cannot both be null.")
val javaType = CodeGenerator.javaType(dataType)
val javaType = JavaCode.javaType(dataType)
val value = CodeGenerator.getValue(ctx.INPUT_ROW, dataType, ordinal.toString)
if (nullable) {
ev.copy(code =
Expand Down
Loading