Revert "[SPARK-22938][SQL][FOLLOWUP] Assert that SQLConf.get is acces…

[cloud-fan]

…sed only on the driver"

This reverts commit a4206d5.

This is from #21299 and to ease the review of it.

[cloud-fan]

cc @gatorsmile @viirya @jiangxb1987

[gatorsmile]

LGTM

[SparkQA]

Test build #90672 has finished for PR 21341 at commit 0674301.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class ImplicitTypeCasts(conf: SQLConf) extends TypeCoercionRule

[viirya]

retest this please.

[viirya]

LGTM

[HyukjinKwon]

LGTM too

[jiangxb1987]

Personally I feel it should be safe to do the revert since we have a better approach, but I'd prefer to hear what @squito think about this.

[SparkQA]

Test build #90673 has finished for PR 21341 at commit 0674301.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class ImplicitTypeCasts(conf: SQLConf) extends TypeCoercionRule

[cloud-fan]

to unblock the improvement PR, I'm going to merge it first and rebase that PR. I will still keep the driver-side check for SparkSession, which is what @squito concerned before.

[cloud-fan]

thanks, merging to master!

[squito]

sure this is fine, but we'll see the flakiness back in the builds till #21299 is merged, right?

[cloud-fan]

Yea we may see flaky test for a while. Fortunately #21299 is there for a while and I think it's close to merge, so it should be fine :)