-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-24253][SQL] Add DeleteSupport mix-in for DataSourceV2. #21308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
46 changes: 46 additions & 0 deletions
46
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DeleteSupport.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.sources.v2; | ||
|
|
||
| import org.apache.spark.sql.sources.Filter; | ||
|
|
||
| /** | ||
| * A mix-in interface for {@link DataSourceV2} delete support. Data sources can implement this | ||
| * interface to provide the ability to delete data from tables that matches filter expressions. | ||
| * <p> | ||
| * Data sources must implement this interface to support logical operations that combine writing | ||
| * data with deleting data, like overwriting partitions. | ||
| */ | ||
| public interface DeleteSupport extends DataSourceV2 { | ||
| /** | ||
| * Delete data from a data source table that matches filter expressions. | ||
| * <p> | ||
| * Rows are deleted from the data source iff all of the filter expressions match. That is, the | ||
| * expressions must be interpreted as a set of filters that are ANDed together. | ||
| * <p> | ||
| * Implementations may reject a delete operation if the delete isn't possible without significant | ||
| * effort. For example, partitioned data sources may reject deletes that do not filter by | ||
| * partition columns because the filter may require rewriting files without deleted records. | ||
| * To reject a delete implementations should throw {@link IllegalArgumentException} with a clear | ||
| * error message that identifies which expression was rejected. | ||
| * | ||
| * @param filters filter expressions, used to select rows to delete when all expressions match | ||
| * @throws IllegalArgumentException If the delete is rejected due to required effort | ||
| */ | ||
| void deleteWhere(Filter[] filters); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems different from what we discussed in the dev list about the new abstraction. I expect to see
Do I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's a little unclear: this delete is not a write. It is a driver-side operation using table metadata, like dropping matching partitions in a Hive table or dropping matching files in an Iceberg table. That way, there are no tasks and we don't need to use the commit protocol.
If we want to filter data files, the overwrite API I've proposed is the right way to do it. Spark could read, filter the rows, and replace all of the files that were read.
If there are files that have both rows that should be removed and rows that should be kept, the source should throw IllegalArgumentException to reject the delete.