[SPARK-24203][core] Add spark.executor.bindAddress #21261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmajercak
changed the title
lukmajercak
changed the title
bjliu
approved these changes
May 7, 2018
Contributor
|
How does this work when you have more than one executor? |
|
Can one of the admins verify this patch? |
Member
|
ping @lukmajercak for @vanzin's comment |
dbtsai
pushed a commit
that referenced
this pull request
Nov 13, 2019
### What changes were proposed in this pull request? With this change, executor's bindAddress is passed as an input parameter for RPCEnv.create. A previous PR #21261 which addressed the same, was using a Spark Conf property to get the bindAddress which wouldn't have worked for multiple executors. This PR is to enable anyone overriding CoarseGrainedExecutorBackend with their custom one to be able to invoke CoarseGrainedExecutorBackend.main() along with the option to configure bindAddress. ### Why are the changes needed? This is required when Kernel-based Virtual Machine (KVM)'s are used inside Linux container where the hostname is not the same as container hostname. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Tested by running jobs with executors on KVMs inside a linux container. Closes #26331 from nishchalv/SPARK-29670. Lead-authored-by: Nishchal Venkataramana <[email protected]> Co-authored-by: nishchal <[email protected]> Signed-off-by: DB Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding spark.executor.bindAddress to allow overriding the address to which the RPC server will bind to on each executor.
How was this patch tested?
Have been running a private build with this in our production cluster for a while.