Skip to content

Conversation

@devaraj-kavali
Copy link

What changes were proposed in this pull request?

Adding -b arg option to take --build-arg parameters to pass into the docker command

How was this patch tested?

I verified by passing proxy details which fails without this change and succeeds with the changes.

@felixcheung
Copy link
Member

felixcheung commented May 1, 2018

@foxish @ifilonenko @mccheah

@felixcheung
Copy link
Member

ok to test

@foxish
Copy link
Contributor

foxish commented May 2, 2018

LGTM pending test run

@foxish
Copy link
Contributor

foxish commented May 2, 2018

jenkins, ok to test

@SparkQA
Copy link

SparkQA commented May 2, 2018

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2727/

@SparkQA
Copy link

SparkQA commented May 2, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2727/

@SparkQA
Copy link

SparkQA commented May 2, 2018

Test build #90033 has finished for PR 21202 at commit 3e410cd.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@devaraj-kavali
Copy link
Author

This patch fails due to an unknown error code, -9.

I don't see any failures related to the change, can you trigger the test again?

@ifilonenko
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented May 7, 2018

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2929/

@SparkQA
Copy link

SparkQA commented May 7, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2929/

@felixcheung
Copy link
Member

ok to test

@felixcheung
Copy link
Member

@devaraj-kavali could you rebase this?

@SparkQA
Copy link

SparkQA commented Jun 11, 2018

Test build #91647 has finished for PR 21202 at commit 3e410cd.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 7, 2018

Test build #92701 has finished for PR 21202 at commit 9c5271d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 18, 2018

@devaraj-kavali @skonto just checking this is still something that should be merged, ready to go?

@devaraj-kavali
Copy link
Author

@srowen this issue still exists and needs to be merged.

@srowen
Copy link
Member

srowen commented Jul 18, 2018

Merged to master

@asfgit asfgit closed this in d404e54 Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants