-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-24129] [K8S] Add option to pass --build-arg's to docker-image-tool.sh #21202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docker-image-tool.sh
|
ok to test |
|
LGTM pending test run |
|
jenkins, ok to test |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #90033 has finished for PR 21202 at commit
|
I don't see any failures related to the change, can you trigger the test again? |
|
retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
ok to test |
|
@devaraj-kavali could you rebase this? |
|
Test build #91647 has finished for PR 21202 at commit
|
|
Test build #92701 has finished for PR 21202 at commit
|
|
@devaraj-kavali @skonto just checking this is still something that should be merged, ready to go? |
|
@srowen this issue still exists and needs to be merged. |
|
Merged to master |
What changes were proposed in this pull request?
Adding
-b argoption to take--build-argparameters to pass into the docker commandHow was this patch tested?
I verified by passing proxy details which fails without this change and succeeds with the changes.