Skip to content

Conversation

@10110346
Copy link
Contributor

@10110346 10110346 commented Apr 16, 2018

What changes were proposed in this pull request?

In the same stage, 'ShuffleDependency' is not necessary to be deserialized each time.

How was this patch tested?

Existing unit test

@SparkQA
Copy link

SparkQA commented Apr 16, 2018

Test build #89394 has finished for PR 21079 at commit 2239e78.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to clear this cache at the end of a app ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to clear, this cache can recovery itself

@10110346 10110346 force-pushed the notdeserializedep branch from 2239e78 to c647f0a Compare April 17, 2018 06:59
@SparkQA
Copy link

SparkQA commented Apr 17, 2018

Test build #89433 has finished for PR 21079 at commit c647f0a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987
Copy link
Contributor

Have you seen any performance improvement with this change?

@HyukjinKwon
Copy link
Member

ping @10110346 for ^

@10110346
Copy link
Contributor Author

I'm sorry to be so late reply to you!
I have tested in my production environment, it has a bit of performance improvement. @jiangxb1987 @HyukjinKwon

@HyukjinKwon
Copy link
Member

Mind if I ask to share the number and post it in the PR description?

@SparkQA
Copy link

SparkQA commented Aug 9, 2018

Test build #94505 has finished for PR 21079 at commit c647f0a.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@10110346 10110346 closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants