Skip to content

Conversation

@squito
Copy link
Contributor

@squito squito commented Apr 11, 2018

SQLMetricsTestUtils.currentExecutionIds() was racing with the listener
bus, which lead to some flaky tests. We should wait till the listener bus is
empty.

I tested by adding some Thread.sleep()s in SQLAppStatusListener, which
reproduced the exceptions I saw on Jenkins. With this change, they went
away.

SQLMetricsTestUtils.currentExecutionIds() was racing with the listener
bus, which lead to some flaky tests.  Wait till the listener bus is
empty.

I tested by adding some Thread.sleep()s in SQLAppStatusListener, which
reproduced the exceptions I saw on Jenkins.  With this change, they went
away.
@SparkQA
Copy link

SparkQA commented Apr 11, 2018

Test build #89204 has finished for PR 21041 at commit 7108d26.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@squito
Copy link
Contributor Author

squito commented Apr 11, 2018

@vanzin @cloud-fan @gatorsmile please take a look, thanks

@cloud-fan
Copy link
Contributor

thanks, merging to master/2.3!

asfgit pushed a commit that referenced this pull request Apr 12, 2018
SQLMetricsTestUtils.currentExecutionIds() was racing with the listener
bus, which lead to some flaky tests.  We should wait till the listener bus is
empty.

I tested by adding some Thread.sleep()s in SQLAppStatusListener, which
reproduced the exceptions I saw on Jenkins.  With this change, they went
away.

Author: Imran Rashid <[email protected]>

Closes #21041 from squito/SPARK-23962.

(cherry picked from commit 6a2289e)
Signed-off-by: Wenchen Fan <[email protected]>
@asfgit asfgit closed this in 6a2289e Apr 12, 2018
@dongjoon-hyun
Copy link
Member

Hi, @squito and @cloud-fan .

Could you take a look at branch-2.3/sbt build?

After this commit on branch-2.3, the following two test cases of ParquetQuerySuite never succeed in branch-2.3/sbt/hadoop-2.6.

For branch-2.3/sbt/hadoop-2.7, 6 test case of DataFrameSuite does, too. For example, the following.

@squito
Copy link
Contributor Author

squito commented Apr 27, 2018

@dongjoon-hyun thanks for reporting this. I think this is the same as https://issues.apache.org/jira/browse/SPARK-23894 . I am nearly certain its not directly caused by this change, but some existing race which has somehow become more common.

I don't totally understand that issue yet -- I'll make a few comments, but would appreciate any help

@squito
Copy link
Contributor Author

squito commented Apr 27, 2018

I submitted a PR for SPARK-23894, #21185, please take a look.

@dongjoon-hyun
Copy link
Member

Thank you, @squito !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants