Skip to content

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

add python api for VectorAssembler handleInvalid

How was this patch tested?

Add doctest

@SparkQA
Copy link

SparkQA commented Apr 7, 2018

Test build #89013 has finished for PR 21003 at commit 2b588ef.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class VectorAssembler(JavaTransformer, HasInputCols, HasOutputCol, HasHandleInvalid, JavaMLReadable,

@SparkQA
Copy link

SparkQA commented Apr 7, 2018

Test build #89015 has finished for PR 21003 at commit 63959c9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

LGTM
But would you mind making one fix in the doc here and in Scala? "Param for how to handle invalid data (NULL values)" should actually read "Param for how to handle invalid data (NULL and NaN values)"

Thanks!

@huaxingao
Copy link
Contributor Author

@jkbradley Thanks for your comment. I will add "and NaN" in the doc.

@SparkQA
Copy link

SparkQA commented Apr 10, 2018

Test build #89156 has finished for PR 21003 at commit 65e7a02.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Merging with master
Thanks @huaxingao !

@asfgit asfgit closed this in 4f1e8b9 Apr 10, 2018
@huaxingao
Copy link
Contributor Author

@jkbradley Thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants