Skip to content

Conversation

@kiszk
Copy link
Member

@kiszk kiszk commented Apr 7, 2018

What changes were proposed in this pull request?

This PR improves test coverage in UTF8StringSuite and code efficiency in UTF8StringPropertyCheckSuite.

This PR also fixes lint-java issue in UTF8StringSuite reported at here

[ERROR] src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:[28,8] (imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.

How was this patch tested?

Existing UT

@kiszk
Copy link
Member Author

kiszk commented Apr 7, 2018

ping @ueshin @hvanhovell @cloud-fan

@SparkQA
Copy link

SparkQA commented Apr 7, 2018

Test build #89006 has finished for PR 21000 at commit 367dd4f.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member Author

kiszk commented Apr 7, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Apr 7, 2018

Test build #89008 has finished for PR 21000 at commit 367dd4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member Author

kiszk commented Apr 7, 2018

Or, is it better to change from

assertTrue(s1.startsWith(s1));
assertTrue(s1.endsWith(s1));

to

assertTrue(s1.startsWith(s1));
assertTrue(s1.endsWith(s1));
assertTrue(s2.startsWith(s2));
assertTrue(s2.endsWith(s2));
assertTrue(s1.startsWith(s2));
assertTrue(s1.endsWith(s2));
assertTrue(s2.startsWith(s1));
assertTrue(s2.endsWith(s1));

?

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. LGTM

@hvanhovell
Copy link
Contributor

LGTM - merging to master. Thanks!

@asfgit asfgit closed this in 710a68c Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants