[SPARK-23656][Test] Perform assertions in XXH64Suite.testKnownByteArrayInputs() on big endian platform, too #20804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #88183 has finished for PR 20804 at commit
|
Member
Author
|
@hvanhovell could you please review this? |
Contributor
|
LGTM - merging to master. Thanks! |
mstewart141
pushed a commit
to mstewart141/spark
that referenced
this pull request
Mar 24, 2018
…ayInputs() on big endian platform, too ## What changes were proposed in this pull request? This PR enables assertions in `XXH64Suite.testKnownByteArrayInputs()` on big endian platform, too. The current implementation performs them only on little endian platform. This PR increase test coverage of big endian platform. ## How was this patch tested? Updated `XXH64Suite` Tested on big endian platform using JIT compiler or interpreter `-Xint`. Author: Kazuaki Ishizaki <[email protected]> Closes apache#20804 from kiszk/SPARK-23656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enables assertions in
XXH64Suite.testKnownByteArrayInputs()on big endian platform, too. The current implementation performs them only on little endian platform. This PR increase test coverage of big endian platform.How was this patch tested?
Updated
XXH64SuiteTested on big endian platform using JIT compiler or interpreter
-Xint.