[MINOR] [SQL] [TEST] Create table using dataSourceName in HadoopFsRelationTest
#20780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sql(s"CREATE TABLE t(i INT) USING $dataSourceName") | ||
| intercept[AnalysisException] { | ||
| testDF.write.format(dataSourceName).mode(SaveMode.ErrorIfExists).saveAsTable("t") | ||
| } |
Member
There was a problem hiding this comment.
Could you add an error message check logic here explicitly?
|
Test build #88112 has finished for PR 20780 at commit
|
HyukjinKwon
approved these changes
Mar 9, 2018
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
lgtm except the comment above
|
Test build #88203 has finished for PR 20780 at commit
|
Member
|
Merged to master. |
mstewart141
pushed a commit
to mstewart141/spark
that referenced
this pull request
Mar 24, 2018
…lationTest` ## What changes were proposed in this pull request? This PR fixes a minor issue in `HadoopFsRelationTest`, that you should create table using `dataSourceName` instead of `parquet`. The issue won't affect the correctness, but it will generate wrong error message in case the test fails. ## How was this patch tested? Exsiting tests. Author: Xingbo Jiang <[email protected]> Closes apache#20780 from jiangxb1987/dataSourceName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a minor issue in
HadoopFsRelationTest, that you should create table usingdataSourceNameinstead ofparquet. The issue won't affect the correctness, but it will generate wrong error message in case the test fails.How was this patch tested?
Exsiting tests.