[SPARK-23601][BUILD] Remove .md5 files from release #20737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC @holdenk @felixcheung who looked at this file recently |
Member
|
The last part with publishing to staging repo (“publish-release”) might not work?
When I did I added a new file .sha512 and it failed the publish, so I wonder if it is specifically looking for certain file extensions. Although I have not tried publishing without the .md5 file or that might have changed now also.
LGTM otherwise
|
|
Test build #87959 has finished for PR 20737 at commit
|
felixcheung
approved these changes
Mar 5, 2018
Member
Author
|
@felixcheung yeah I don't see any more references to .md5 files now; certainly I don't see anything in the script that would fail if it's not there. I also don't know of any process at the ASF or Nexus that should care about it. I suppose it's one of those things we'd find out next time; not sure if there's any way to test that part of the release process without actually releasing. |
Member
Author
|
Merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Mar 6, 2018
## What changes were proposed in this pull request? Remove .md5 files from release artifacts ## How was this patch tested? N/A Author: Sean Owen <[email protected]> Closes #20737 from srowen/SPARK-23601. (cherry picked from commit 8bceb89) Signed-off-by: Sean Owen <[email protected]>
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
## What changes were proposed in this pull request? Remove .md5 files from release artifacts ## How was this patch tested? N/A Author: Sean Owen <[email protected]> Closes apache#20737 from srowen/SPARK-23601. (cherry picked from commit 8bceb89) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove .md5 files from release artifacts
How was this patch tested?
N/A