Skip to content

[MLlib][SPARK-2997] Update SVD documentation to reflect roughly square #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[MLlib][SPARK-2997] Update SVD documentation to reflect roughly square #2070

wants to merge 7 commits into from

Conversation

@rezazadeh
Copy link
Contributor

@rezazadeh rezazadeh commented Aug 21, 2014

Update the documentation to reflect the fact we can handle roughly square matrices.

atalwalkar
atalwalkar reviewed Aug 21, 2014
View reviewed changes
docs/mllib-dimensionality-reduction.md Outdated
Copy link
Contributor

@atalwalkar atalwalkar Aug 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a link to the scaladoc or the documentation for RowMatrix?

Copy link
Contributor

@atalwalkar atalwalkar Aug 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give some high-level guidance on the scalability of our approaches / what sorts of matrices and values of k on which its appropriate to run MLlib's SVD?

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have started for PR 2070 at commit 6429c59.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have started for PR 2070 at commit 7ffa2aa.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have finished for PR 2070 at commit 6429c59.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have finished for PR 2070 at commit 7ffa2aa.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

mengxr
mengxr reviewed Aug 21, 2014
View reviewed changes
docs/mllib-dimensionality-reduction.md Outdated
Copy link
Contributor

@mengxr mengxr Aug 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need tall-and-skinny matrices for PCA.

@SparkQA
Copy link

SparkQA commented Aug 22, 2014

QA tests have started for PR 2070 at commit 3f34fc6.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 22, 2014

QA tests have finished for PR 2070 at commit 3f34fc6.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@atalwalkar
Copy link
Contributor

atalwalkar commented Aug 22, 2014

Aside from the one issue of $U$ being the left singular vectors, this looks good to me.

@SparkQA
Copy link

SparkQA commented Aug 23, 2014

QA tests have started for PR 2070 at commit 826b8fe.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 23, 2014

QA tests have finished for PR 2070 at commit 826b8fe.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 25, 2014

I've merged this into master and branch-1.1. Thanks!!

@asfgit asfgit closed this in b1b2030 Aug 25, 2014
asfgit pushed a commit that referenced this pull request Aug 25, 2014
@rezazadeh @mengxr
[MLlib][SPARK-2997] Update SVD documentation to reflect roughly square
749bddc 
Update the documentation to reflect the fact we can handle roughly square matrices.

Author: Reza Zadeh <[email protected]>

Closes #2070 from rezazadeh/svddocs and squashes the following commits:

826b8fe [Reza Zadeh] left singular vectors
3f34fc6 [Reza Zadeh] PCA is still TS
7ffa2aa [Reza Zadeh] better title
aeaf39d [Reza Zadeh] More docs
788ed13 [Reza Zadeh] add computational cost explanation
6429c59 [Reza Zadeh] Add link to rowmatrix docs
1eeab8b [Reza Zadeh] Update SVD documentation to reflect roughly square

(cherry picked from commit b1b2030)
Signed-off-by: Xiangrui Meng <[email protected]>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@rezazadeh @conviva-zz
[MLlib][SPARK-2997] Update SVD documentation to reflect roughly square
1fa8ebd 
Update the documentation to reflect the fact we can handle roughly square matrices.

Author: Reza Zadeh <[email protected]>

Closes apache#2070 from rezazadeh/svddocs and squashes the following commits:

826b8fe [Reza Zadeh] left singular vectors
3f34fc6 [Reza Zadeh] PCA is still TS
7ffa2aa [Reza Zadeh] better title
aeaf39d [Reza Zadeh] More docs
788ed13 [Reza Zadeh] add computational cost explanation
6429c59 [Reza Zadeh] Add link to rowmatrix docs
1eeab8b [Reza Zadeh] Update SVD documentation to reflect roughly square
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rezazadeh @SparkQA @atalwalkar @mengxr