[SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of OptimizeMetadataOnlyQuery #20693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM - pending jenkins |
|
Test build #87775 has finished for PR 20693 at commit
|
cloud-fan
reviewed
Feb 28, 2018
| data: Seq[InternalRow] = Nil, | ||
| // Indicates whether this relation has data from a streaming source. | ||
| override val isStreaming: Boolean = false) | ||
| case class LocalRelation(output: Seq[Attribute], |
Contributor
There was a problem hiding this comment.
although we should not include this style change in the original commit, since it's already there, let's not bother about reverting it back.
Contributor
|
retest this please |
Contributor
|
LGTM |
|
Test build #87783 has finished for PR 20693 at commit
|
|
Test build #87787 has finished for PR 20693 at commit
|
gatorsmile
pushed a commit
to gatorsmile/spark
that referenced
this pull request
Mar 7, 2018
## What changes were proposed in this pull request? Inside `OptimizeMetadataOnlyQuery.getPartitionAttrs`, avoid using `zip` to generate attribute map. Also include other minor update of comments and format. ## How was this patch tested? Existing test cases. Author: Xingbo Jiang <[email protected]> Closes apache#20693 from jiangxb1987/SPARK-23523.
asfgit
pushed a commit
that referenced
this pull request
Mar 13, 2018
…he rule OptimizeMetadataOnlyQuery This PR is to backport #20684 and #20693 to Spark 2.3 branch --- ## What changes were proposed in this pull request? ```Scala val tablePath = new File(s"${path.getCanonicalPath}/cOl3=c/cOl1=a/cOl5=e") Seq(("a", "b", "c", "d", "e")).toDF("cOl1", "cOl2", "cOl3", "cOl4", "cOl5") .write.json(tablePath.getCanonicalPath) val df = spark.read.json(path.getCanonicalPath).select("CoL1", "CoL5", "CoL3").distinct() df.show() ``` It generates a wrong result. ``` [c,e,a] ``` We have a bug in the rule `OptimizeMetadataOnlyQuery `. We should respect the attribute order in the original leaf node. This PR is to fix it. ## How was this patch tested? Added a test case Author: Xingbo Jiang <[email protected]> Author: gatorsmile <[email protected]> Closes #20763 from gatorsmile/backport23523.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
## What changes were proposed in this pull request? Inside `OptimizeMetadataOnlyQuery.getPartitionAttrs`, avoid using `zip` to generate attribute map. Also include other minor update of comments and format. ## How was this patch tested? Existing test cases. Author: Xingbo Jiang <[email protected]> Closes apache#20693 from jiangxb1987/SPARK-23523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Inside
OptimizeMetadataOnlyQuery.getPartitionAttrs, avoid usingzipto generate attribute map.Also include other minor update of comments and format.
How was this patch tested?
Existing test cases.