[SPARK-23449][K8S] Preserve extraJavaOptions ordering #20628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is necessary.
andrusha
changed the title
andrusha
changed the title
Contributor
|
also cc @vanzin to verify this change. |
Contributor
|
ok to test |
|
Test build #87680 has finished for PR 20628 at commit
|
Contributor
|
LGTM, pending tests. I hope we can just use spark-submit here at some point. |
Contributor
|
Merging to master / 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Feb 26, 2018
For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is necessary. ## What changes were proposed in this pull request? Keep original `extraJavaOptions` ordering, when passing them through environment variables inside the Docker container. ## How was this patch tested? Ran base branch a couple of times and checked startup command in logs. Ordering differed every time. Added sorting, ordering was consistent to what user had in `extraJavaOptions`. Author: Andrew Korzhuev <[email protected]> Closes #20628 from andrusha/patch-2. (cherry picked from commit 185f5bc) Signed-off-by: Marcelo Vanzin <[email protected]>
andrusha
added a commit
to andrusha/spark
that referenced
this pull request
Apr 5, 2018
For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is necessary. ## What changes were proposed in this pull request? Keep original `extraJavaOptions` ordering, when passing them through environment variables inside the Docker container. ## How was this patch tested? Ran base branch a couple of times and checked startup command in logs. Ordering differed every time. Added sorting, ordering was consistent to what user had in `extraJavaOptions`. Author: Andrew Korzhuev <[email protected]> Closes apache#20628 from andrusha/patch-2. (cherry picked from commit 185f5bc) Signed-off-by: Marcelo Vanzin <[email protected]>
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is necessary. ## What changes were proposed in this pull request? Keep original `extraJavaOptions` ordering, when passing them through environment variables inside the Docker container. ## How was this patch tested? Ran base branch a couple of times and checked startup command in logs. Ordering differed every time. Added sorting, ordering was consistent to what user had in `extraJavaOptions`. Author: Andrew Korzhuev <[email protected]> Closes apache#20628 from andrusha/patch-2. (cherry picked from commit 185f5bc) Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some JVM options, like
-XX:+UnlockExperimentalVMOptionsordering is necessary.What changes were proposed in this pull request?
Keep original
extraJavaOptionsordering, when passing them through environment variables inside the Docker container.How was this patch tested?
Ran base branch a couple of times and checked startup command in logs. Ordering differed every time. Added sorting, ordering was consistent to what user had in
extraJavaOptions.