[SPARK-23438][DSTREAMS] Fix DStreams data loss with WAL when driver crashes #20620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jose-torres @tdas @zsxwing could you take a look at this please? |
Contributor
|
ok to test |
|
Test build #87489 has finished for PR 20620 at commit
|
|
Test build #87494 has finished for PR 20620 at commit
|
viirya
reviewed
Feb 17, 2018
| s"${allocatedBlocks.streamIdToAllocatedBlocks}") | ||
| streamIdToUnallocatedBlockQueues.values.foreach { _.clear() } | ||
| allocatedBlocks.streamIdToAllocatedBlocks.foreach { | ||
| case (streamId, allocatedBlocks) => |
Member
There was a problem hiding this comment.
nit: Can we use another name (maybe allocatedBlocksInStream?) other than allocatedBlocks to avoid confusion?
|
Test build #87519 has finished for PR 20620 at commit
|
Contributor
Author
|
Seems like unrelated issue. |
Member
|
retest this please. |
|
Test build #87522 has finished for PR 20620 at commit
|
Contributor
|
LGTM. |
Contributor
|
Merging to master, will try back to 2.0. |
Contributor
|
(Argh, the wifi here is horrible, I'll need to manually merge things, so hang on a sec...) |
asfgit
pushed a commit
that referenced
this pull request
Feb 26, 2018
…rashes There is a race condition introduced in SPARK-11141 which could cause data loss. The problem is that ReceivedBlockTracker.insertAllocatedBatch function assumes that all blocks from streamIdToUnallocatedBlockQueues allocated to the batch and clears the queue. In this PR only the allocated blocks will be removed from the queue which will prevent data loss. Additional unit test + manually. Author: Gabor Somogyi <[email protected]> Closes #20620 from gaborgsomogyi/SPARK-23438. (cherry picked from commit b308182) Signed-off-by: Marcelo Vanzin <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 26, 2018
…rashes There is a race condition introduced in SPARK-11141 which could cause data loss. The problem is that ReceivedBlockTracker.insertAllocatedBatch function assumes that all blocks from streamIdToUnallocatedBlockQueues allocated to the batch and clears the queue. In this PR only the allocated blocks will be removed from the queue which will prevent data loss. Additional unit test + manually. Author: Gabor Somogyi <[email protected]> Closes #20620 from gaborgsomogyi/SPARK-23438. (cherry picked from commit b308182) Signed-off-by: Marcelo Vanzin <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 26, 2018
…rashes There is a race condition introduced in SPARK-11141 which could cause data loss. The problem is that ReceivedBlockTracker.insertAllocatedBatch function assumes that all blocks from streamIdToUnallocatedBlockQueues allocated to the batch and clears the queue. In this PR only the allocated blocks will be removed from the queue which will prevent data loss. Additional unit test + manually. Author: Gabor Somogyi <[email protected]> Closes #20620 from gaborgsomogyi/SPARK-23438. (cherry picked from commit b308182) Signed-off-by: Marcelo Vanzin <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 26, 2018
…rashes There is a race condition introduced in SPARK-11141 which could cause data loss. The problem is that ReceivedBlockTracker.insertAllocatedBatch function assumes that all blocks from streamIdToUnallocatedBlockQueues allocated to the batch and clears the queue. In this PR only the allocated blocks will be removed from the queue which will prevent data loss. Additional unit test + manually. Author: Gabor Somogyi <[email protected]> Closes #20620 from gaborgsomogyi/SPARK-23438. (cherry picked from commit b308182) Signed-off-by: Marcelo Vanzin <[email protected]>
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…rashes There is a race condition introduced in SPARK-11141 which could cause data loss. The problem is that ReceivedBlockTracker.insertAllocatedBatch function assumes that all blocks from streamIdToUnallocatedBlockQueues allocated to the batch and clears the queue. In this PR only the allocated blocks will be removed from the queue which will prevent data loss. Additional unit test + manually. Author: Gabor Somogyi <[email protected]> Closes apache#20620 from gaborgsomogyi/SPARK-23438. (cherry picked from commit b308182) Signed-off-by: Marcelo Vanzin <[email protected]>
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…rashes There is a race condition introduced in SPARK-11141 which could cause data loss. The problem is that ReceivedBlockTracker.insertAllocatedBatch function assumes that all blocks from streamIdToUnallocatedBlockQueues allocated to the batch and clears the queue. In this PR only the allocated blocks will be removed from the queue which will prevent data loss. Additional unit test + manually. Author: Gabor Somogyi <[email protected]> Closes apache#20620 from gaborgsomogyi/SPARK-23438. (cherry picked from commit b308182) Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is a race condition introduced in SPARK-11141 which could cause data loss.
The problem is that ReceivedBlockTracker.insertAllocatedBatch function assumes that all blocks from streamIdToUnallocatedBlockQueues allocated to the batch and clears the queue.
In this PR only the allocated blocks will be removed from the queue which will prevent data loss.
How was this patch tested?
Additional unit test + manually.