Skip to content

Conversation

@gaborgsomogyi
Copy link
Contributor

…D_CLASSES set to 1

What changes were proposed in this pull request?

YarnShuffleIntegrationSuite fails when SPARK_PREPEND_CLASSES set to 1.

Normally mllib built before yarn module. When SPARK_PREPEND_CLASSES used mllib classes are on yarn test classpath.

Before 2.3 that did not cause issues. But 2.3 has SPARK-22450, which registered some mllib classes with the kryo serializer. Now it dies with the following error:

18/02/13 07:33:29 INFO SparkContext: Starting job: collect at YarnShuffleIntegrationSuite.scala:143 Exception in thread "dag-scheduler-event-loop" java.lang.NoClassDefFoundError: breeze/linalg/DenseMatrix

In this PR NoClassDefFoundError caught only in case of testing and then do nothing.

How was this patch tested?

Automated: Pass the Jenkins.

@gaborgsomogyi
Copy link
Contributor Author

cc @ConeyLiu @vanzin

@vanzin
Copy link
Contributor

vanzin commented Feb 14, 2018

ok to test

@SparkQA
Copy link

SparkQA commented Feb 14, 2018

Test build #87449 has finished for PR 20608 at commit 9c1c415.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Feb 15, 2018

Merging to master / 2.3.

asfgit pushed a commit that referenced this pull request Feb 15, 2018
…D_CLASSES set to 1

## What changes were proposed in this pull request?

YarnShuffleIntegrationSuite fails when SPARK_PREPEND_CLASSES set to 1.

Normally mllib built before yarn module. When SPARK_PREPEND_CLASSES used mllib classes are on yarn test classpath.

Before 2.3 that did not cause issues. But 2.3 has SPARK-22450, which registered some mllib classes with the kryo serializer. Now it dies with the following error:

`
18/02/13 07:33:29 INFO SparkContext: Starting job: collect at YarnShuffleIntegrationSuite.scala:143
Exception in thread "dag-scheduler-event-loop" java.lang.NoClassDefFoundError: breeze/linalg/DenseMatrix
`

In this PR NoClassDefFoundError caught only in case of testing and then do nothing.

## How was this patch tested?

Automated: Pass the Jenkins.

Author: Gabor Somogyi <[email protected]>

Closes #20608 from gaborgsomogyi/SPARK-23422.

(cherry picked from commit 44e20c4)
Signed-off-by: Marcelo Vanzin <[email protected]>
@asfgit asfgit closed this in 44e20c4 Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants