[SPARK-23419][SPARK-23416][SS] data source v2 write path should re-throw interruption exceptions directly #20605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #87437 has finished for PR 20605 at commit
|
Member
Contributor
|
This seems good to me. My only concern is that we still have to rely/maintain a list of exceptions thrown when the stop method is called... This approach seems not very robust to me, but I don't have a better suggestion. |
Contributor
|
LGTM also. I'll still take it as an action item to try and think of a cleaner way to handle stopping a stream. |
Member
|
LGTM |
Contributor
Author
|
thanks, merging to master/2.3! Since it's a bug fix so I included it in branch 2.3, please let me know if you have other concerns, cc @sameeragarwal @marmbrus |
asfgit
pushed a commit
that referenced
this pull request
Feb 15, 2018
…row interruption exceptions directly ## What changes were proposed in this pull request? Streaming execution has a list of exceptions that means interruption, and handle them specially. `WriteToDataSourceV2Exec` should also respect this list and not wrap them with `SparkException`. ## How was this patch tested? existing test. Author: Wenchen Fan <[email protected]> Closes #20605 from cloud-fan/write. (cherry picked from commit f38c760) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Streaming execution has a list of exceptions that means interruption, and handle them specially.
WriteToDataSourceV2Execshould also respect this list and not wrap them withSparkException.How was this patch tested?
existing test.