[SPARK-23418][SQL]: Fail DataSourceV2 reads when user schema is passed, but not supported. #20603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cloud-fan, here's the PR to fix user-supplied schema behavior. Once #20387 is committed, I'll rebase and remove its commits from this PR. |
rdblue
force-pushed
the
SPARK-23418-revert-adcb25a0624
branch
from
f623080 to
bd06193
Compare
|
Test build #87428 has finished for PR 20603 at commit
|
|
Test build #87431 has finished for PR 20603 at commit
|
This reverts commit adcb25a06240dc413f58b2d1240405b0a5485578.
rdblue
force-pushed
the
SPARK-23418-revert-adcb25a0624
branch
from
bd06193 to
a963a5d
Compare
Contributor
Author
|
@cloud-fan, this implements SPARK-23418, which rejects user-supplied schemas when ReadSupportWithSchema is not available. |
|
Test build #87559 has finished for PR 20603 at commit
|
Contributor
|
thanks, merging to master! |
Contributor
Author
|
Thanks for reviewing, @cloud-fan! |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…, but not supported. DataSourceV2 initially allowed user-supplied schemas when a source doesn't implement `ReadSupportWithSchema`, as long as the schema was identical to the source's schema. This is confusing behavior because changes to an underlying table can cause a previously working job to fail with an exception that user-supplied schemas are not allowed. This reverts commit adcb25a0624, which was added to apache#20387 so that it could be removed in a separate JIRA issue and PR. Existing tests. Author: Ryan Blue <[email protected]> Closes apache#20603 from rdblue/SPARK-23418-revert-adcb25a0624. Ref: LIHADOOP-48531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DataSourceV2 initially allowed user-supplied schemas when a source doesn't implement
ReadSupportWithSchema, as long as the schema was identical to the source's schema. This is confusing behavior because changes to an underlying table can cause a previously working job to fail with an exception that user-supplied schemas are not allowed.This reverts commit adcb25a0624, which was added to #20387 so that it could be removed in a separate JIRA issue and PR.
How was this patch tested?
Existing tests.