[SPARK-23400] [SQL] Add a constructors for ScalaUDF #20591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #87352 has finished for PR 20591 at commit
|
Contributor
|
The JIRA ID is wrong... |
gatorsmile
changed the title
gatorsmile
changed the title
|
Test build #87363 has finished for PR 20591 at commit
|
Contributor
|
retest this please |
|
Test build #87380 has finished for PR 20591 at commit
|
Contributor
|
retest this please |
|
Test build #87390 has finished for PR 20591 at commit
|
Member
|
LGTM. Merging to master and 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2018
## What changes were proposed in this pull request? In this upcoming 2.3 release, we changed the interface of `ScalaUDF`. Unfortunately, some Spark packages (e.g., spark-deep-learning) are using our internal class `ScalaUDF`. In the release 2.3, we added new parameters into this class. The users hit the binary compatibility issues and got the exception: ``` > java.lang.NoSuchMethodError: org.apache.spark.sql.catalyst.expressions.ScalaUDF.<init>(Ljava/lang/Object;Lorg/apache/spark/sql/types/DataType;Lscala/collection/Seq;Lscala/collection/Seq;Lscala/Option;)V ``` This PR is to improve the backward compatibility. However, we definitely should not encourage the external packages to use our internal classes. This might make us hard to maintain/develop the codes in Spark. ## How was this patch tested? N/A Author: gatorsmile <[email protected]> Closes #20591 from gatorsmile/scalaUDF. (cherry picked from commit 2ee76c2) Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this upcoming 2.3 release, we changed the interface of
ScalaUDF. Unfortunately, some Spark packages (e.g., spark-deep-learning) are using our internal classScalaUDF. In the release 2.3, we added new parameters into this class. The users hit the binary compatibility issues and got the exception:This PR is to improve the backward compatibility. However, we definitely should not encourage the external packages to use our internal classes. This might make us hard to maintain/develop the codes in Spark.
How was this patch tested?
N/A