Skip to content

[SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for Rows. #20503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for Rows. #20503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6604e9f
Fix __repr__ behaviour for Rows.
ashashwat Feb 4, 2018
890aa65
Unicode fix.
ashashwat Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/pyspark/sql/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ def test_empty_row(self):
row = Row()
self.assertEqual(len(row), 0)

def test_row_without_column_name(self):
row = Row("Alice", 11)
Copy link
Member

@HyukjinKwon HyukjinKwon Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a doctest for this usage (Row as objects not as a namedtuple class), and documentation in Row at types.py?

self.assertEqual(row.__repr__(), "<Row(Alice, 11)>")
Copy link
Member

@HyukjinKwon HyukjinKwon Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would test non-ascii compatible characters as well


def test_struct_field_type_name(self):
struct_field = StructField("a", IntegerType())
self.assertRaises(TypeError, struct_field.typeName)
Expand Down
2 changes: 1 addition & 1 deletion python/pyspark/sql/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,7 +1581,7 @@ def __repr__(self):
return "Row(%s)" % ", ".join("%s=%r" % (k, v)
for k, v in zip(self.__fields__, tuple(self)))
else:
return "<Row(%s)>" % ", ".join(self)
return "<Row(%s)>" % ", ".join("%s" % (fields) for fields in self)
Copy link
Member

@HyukjinKwon HyukjinKwon Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit fields => field

Copy link
Member

@HyukjinKwon HyukjinKwon Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"%s" % (fields) for fields in self -> "%s" % field for field in self



class DateConverter(object):
Expand Down