Skip to content

Revert "[SPARK-21658][SQL][PYSPARK] Add default None for value in na.replace in PySpark" #20496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "[SPARK-21658][SQL][PYSPARK] Add default None for value in na.replace in PySpark" #20496

wants to merge 1 commit into from

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Feb 3, 2018

This reverts commit 0fcde87.

See the discussion in SPARK-21658, SPARK-19454 and #16793

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Feb 3, 2018 •
edited
Loading

cc @rxin, @gatorsmile, @holdenk, @zero323 and @viirya.

@SparkQA
Copy link

SparkQA commented Feb 3, 2018

Test build #87028 has finished for PR 20496 at commit 8a93164.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun
dongjoon-hyun approved these changes Feb 3, 2018
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@gatorsmile
Copy link
Member

gatorsmile commented Feb 3, 2018

LGTM

Thanks for your quick PR! Merged to master/2.3

@asfgit asfgit closed this in 551dff2 Feb 3, 2018
asfgit pushed a commit that referenced this pull request Feb 3, 2018
@HyukjinKwon @gatorsmile
[SPARK-21658][SQL][PYSPARK] Revert "[] Add default None for value in …
45f0f4f 
…na.replace in PySpark"

This reverts commit 0fcde87.

See the discussion in [SPARK-21658](https://issues.apache.org/jira/browse/SPARK-21658),  [SPARK-19454](https://issues.apache.org/jira/browse/SPARK-19454) and #16793

Author: hyukjinkwon <[email protected]>

Closes #20496 from HyukjinKwon/revert-SPARK-21658.

(cherry picked from commit 551dff2)
Signed-off-by: gatorsmile <[email protected]>
@HyukjinKwon HyukjinKwon mentioned this pull request Feb 3, 2018
Closed
@HyukjinKwon HyukjinKwon deleted the revert-SPARK-21658 branch October 16, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HyukjinKwon @SparkQA @gatorsmile @dongjoon-hyun