[SPARK-2312] Logging Unhandled messages

[isaias]

Note about tests: The best way to write tests for Log is use the TestEventListener and EventFilter of Akka, but the current Actors aren't using default ActorLogging and the current configuration are outputting results to a file instead STDOUT.

[AmplabJenkins]

Can one of the admins verify this patch?

[rxin]

Why don't we just change ActorLogReceive to log messages not defined in the partial function?

[isaias]

@rxin, the trait ActorLogReceive gets the concrete implementation through receiveWithLogging function overriding of implementing Actor and applying it, so I think that on trait I can't identify the unhandled message of concrete implementation. Maybe I'm missing something, but I'll review.

BR

[rxin]

You just need to change

    override def isDefinedAt(o: Any): Boolean = _receiveWithLogging.isDefinedAt(o)

to

    override def isDefinedAt(o: Any): Boolean = {
      val handled = _receiveWithLogging.isDefinedAt(o)
      if (!handled) {
        log ...
      }
      handled
    }

[isaias]

@rxin Very nice, it works. Should be better to close this PR and send another just with the trait changes?

BR

[rxin]

Sure.

[isaias]

Thanks