Skip to content

Conversation

@MLnick
Copy link
Contributor

@MLnick MLnick commented Jan 29, 2018

Add breaking changes, as well as update behavior changes, to 2.3 ML migration guide.

How was this patch tested?

Doc only

@SparkQA
Copy link

SparkQA commented Jan 29, 2018

Test build #86767 has finished for PR 20421 at commit b6fcf15.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86802 has finished for PR 20421 at commit 4433d9c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Contributor Author

MLnick commented Jan 30, 2018

@felixcheung just added a few more behavior changes I found. Should be final now.

@MLnick MLnick changed the title [SPARK-23112][DOC] Update ML migration guide with breaking changes. [SPARK-23112][DOC] Update ML migration guide with breaking and behavior changes. Jan 30, 2018
@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86807 has finished for PR 20421 at commit 4a957f6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86808 has finished for PR 20421 at commit 469d87d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MLnick
Copy link
Contributor Author

MLnick commented Jan 31, 2018

Merged to master / branch-2.3. Thanks!

asfgit pushed a commit that referenced this pull request Jan 31, 2018
…or changes.

Add breaking changes, as well as update behavior changes, to `2.3` ML migration guide.

## How was this patch tested?

Doc only

Author: Nick Pentreath <[email protected]>

Closes #20421 from MLnick/SPARK-23112-ml-guide.

(cherry picked from commit 161a3f2)
Signed-off-by: Nick Pentreath <[email protected]>
@asfgit asfgit closed this in 161a3f2 Jan 31, 2018
@WeichenXu123
Copy link
Contributor

@MLnick
Forget one fix: #18797
I doubt whether this fix should go into "behavior change". It influences iteration number for algos use LBFGS, although it is a bugfix (this bug is introduced in spark 2.2).

@MLnick
Copy link
Contributor Author

MLnick commented Jan 31, 2018 via email

@WeichenXu123
Copy link
Contributor

ah, yes, it backport to 2.2 😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants