[SPARK-23163][DOC][PYTHON] Sync ML Python API with Scala #20354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #86498 has finished for PR 20354 at commit
|
MLnick
approved these changes
Jan 23, 2018
Contributor
MLnick
left a comment
MLnick
left a comment
There was a problem hiding this comment.
LGTM - not sure if we will merge this into branch-2.3 as RC2 has been cut. Let's wait a bit and see.
felixcheung
approved these changes
Jan 24, 2018
Member
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
LGTM.
I guess they are not blockers, but we should probably merge to branch-2.3?
Contributor
|
I'd say branch-2.3 since we want the fix in 2.3.1 even if it isn't in 2.3.0. |
Member
|
merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Jan 25, 2018
## What changes were proposed in this pull request? This syncs the ML Python API with Scala for differences found after the 2.3 QA audit. ## How was this patch tested? NA Author: Bryan Cutler <[email protected]> Closes #20354 from BryanCutler/pyspark-ml-doc-sync-23163. (cherry picked from commit 39ee2ac) Signed-off-by: Felix Cheung <[email protected]>
Member
Author
|
Thanks @felixcheung and others for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This syncs the ML Python API with Scala for differences found after the 2.3 QA audit.
How was this patch tested?
NA