Skip to content

Conversation

@foxish
Copy link
Contributor

@foxish foxish commented Jan 18, 2018

What changes were proposed in this pull request?

Pass through spark java options to the executor in context of docker image.
Closes #20296

How was this patch tested?

@andrusha: Deployed two version of containers to local k8s, checked that java options were present in the updated image on the running executor.
Manual test

@vanzin
Copy link
Contributor

vanzin commented Jan 18, 2018

Could you copy the title / description from the other PR instead of referencing it?

@vanzin
Copy link
Contributor

vanzin commented Jan 18, 2018

(And also add "Closes #20296" so that it's automatically closed when we push this.)

@SparkQA
Copy link

SparkQA commented Jan 18, 2018

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/13/

@SparkQA
Copy link

SparkQA commented Jan 18, 2018

Test build #86356 has finished for PR 20322 at commit 903179c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jan 18, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/13/

@vanzin
Copy link
Contributor

vanzin commented Jan 18, 2018

Merging to master / 2.3.

asfgit pushed a commit that referenced this pull request Jan 18, 2018
Pass through spark java options to the executor in context of docker image.
Closes #20296

andrusha: Deployed two version of containers to local k8s, checked that java options were present in the updated image on the running executor.
Manual test

Author: Andrew Korzhuev <[email protected]>

Closes #20322 from foxish/patch-1.

(cherry picked from commit f568e9c)
Signed-off-by: Marcelo Vanzin <[email protected]>
@asfgit asfgit closed this in f568e9c Jan 18, 2018
@foxish foxish deleted the patch-1 branch February 27, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants