-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-23028] Bump master branch version to 2.4.0-SNAPSHOT #20222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -181,8 +181,8 @@ def main(): | |
| short_commit_hash = ghprb_actual_commit[0:7] | ||
|
|
||
| # format: http://linux.die.net/man/1/timeout | ||
| # must be less than the timeout configured on Jenkins (currently 300m) | ||
| tests_timeout = "250m" | ||
| # must be less than the timeout configured on Jenkins (currently 350m) | ||
| tests_timeout = "300m" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, this was the root causes. Thanks, @HyukjinKwon . |
||
|
|
||
| # Array to capture all test names to run on the pull request. These tests are represented | ||
| # by their file equivalents in the dev/tests/ directory. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,10 @@ import com.typesafe.tools.mima.core.ProblemFilters._ | |
| */ | ||
| object MimaExcludes { | ||
|
|
||
| // Exclude rules for 2.4.x | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This reminds me that we should probably bump See #15061 for an example of a similar change when 2.1.x was being prepared (it looks like we missed this step for 2.2.0). We may also need to un-exclude any new subprojects / artifacts that were added in 2.2.0 since they now need to be backwards-compatibility-tested for 2.3.x. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might want to make my proposed MiMa changes in a separate patch so the same set of reviewed changes can go to both master and branch-2.3. |
||
| lazy val v24excludes = v23excludes ++ Seq( | ||
| ) | ||
|
|
||
| // Exclude rules for 2.3.x | ||
| lazy val v23excludes = v22excludes ++ Seq( | ||
| // [SPARK-22897] Expose stageAttemptId in TaskContext | ||
|
|
@@ -1082,6 +1086,7 @@ object MimaExcludes { | |
| } | ||
|
|
||
| def excludes(version: String) = version match { | ||
| case v if v.startsWith("2.4") => v24excludes | ||
| case v if v.startsWith("2.3") => v23excludes | ||
| case v if v.startsWith("2.2") => v22excludes | ||
| case v if v.startsWith("2.1") => v21excludes | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal but seems currently we set it to
361min Jenkins now - cc @shaneknapp.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment is OK.