Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

When users' DB description is NULL, users might hit NullPointerException. This PR is to fix the issue.

How was this patch tested?

Added test cases

@SparkQA
Copy link

SparkQA commented Jan 10, 2018

Test build #85903 has finished for PR 20215 at commit 137fd7a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 10, 2018

Test build #85909 has finished for PR 20215 at commit 2fe541f.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Jan 10, 2018

Test build #85913 has finished for PR 20215 at commit 2fe541f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

cc @cloud-fan @sameeragarwal

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@cloud-fan
Copy link
Contributor

cloud-fan commented Jan 11, 2018

thanks, merging to master/2.3/2.2!

asfgit pushed a commit that referenced this pull request Jan 11, 2018
… NULL description

## What changes were proposed in this pull request?
When users' DB description is NULL, users might hit `NullPointerException`. This PR is to fix the issue.

## How was this patch tested?
Added test cases

Author: gatorsmile <[email protected]>

Closes #20215 from gatorsmile/SPARK-23001.

(cherry picked from commit 87c98de)
Signed-off-by: Wenchen Fan <[email protected]>
asfgit pushed a commit that referenced this pull request Jan 11, 2018
… NULL description

## What changes were proposed in this pull request?
When users' DB description is NULL, users might hit `NullPointerException`. This PR is to fix the issue.

## How was this patch tested?
Added test cases

Author: gatorsmile <[email protected]>

Closes #20215 from gatorsmile/SPARK-23001.

(cherry picked from commit 87c98de)
Signed-off-by: Wenchen Fan <[email protected]>
@asfgit asfgit closed this in 87c98de Jan 11, 2018
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
… NULL description

## What changes were proposed in this pull request?
When users' DB description is NULL, users might hit `NullPointerException`. This PR is to fix the issue.

## How was this patch tested?
Added test cases

Author: gatorsmile <[email protected]>

Closes apache#20215 from gatorsmile/SPARK-23001.

(cherry picked from commit 87c98de)
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants