Skip to content

[HOTFIX] Fix style checking failure #20175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HOTFIX] Fix style checking failure #20175

wants to merge 1 commit into from

Conversation

@gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Jan 6, 2018

What changes were proposed in this pull request?

This PR is to fix the style checking failure.

How was this patch tested?

N/A

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 6, 2018

@gatorsmile . Could you check Java style, too?

$ dev/lint-java
Using `mvn` from path: /usr/local/maven-3.5.2/bin/mvn
Checkstyle checks failed at following occurrences:
[ERROR] src/main/java/org/apache/spark/launcher/InProcessAppHandle.java:[20,8] (imports) UnusedImports: Unused import - java.io.IOException.
[ERROR] src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java:[464] (sizes) LineLength: Line is longer than 100 characters (found 102).

@gatorsmile
Copy link
Member Author

gatorsmile commented Jan 6, 2018

@dongjoon-hyun The JAVA style check is disabled.

@SparkQA
Copy link

SparkQA commented Jan 6, 2018

Test build #85755 has finished for PR 20175 at commit 6b4ddcc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

gatorsmile commented Jan 6, 2018

Thanks! Merged to master/2.3

asfgit pushed a commit that referenced this pull request Jan 6, 2018
@gatorsmile
[HOTFIX] Fix style checking failure
f9e7b0c 
## What changes were proposed in this pull request?
This PR is to fix the  style checking failure.

## How was this patch tested?
N/A

Author: gatorsmile <[email protected]>

Closes #20175 from gatorsmile/stylefix.

(cherry picked from commit 9a7048b)
Signed-off-by: gatorsmile <[email protected]>
@asfgit asfgit closed this in 9a7048b Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gatorsmile @dongjoon-hyun @SparkQA @HyukjinKwon