[SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error messages to show actual versions. #20074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Dec 25, 2017
python/pyspark/sql/utils.py
Outdated
| import pandas | ||
| if LooseVersion(pandas.__version__) < LooseVersion('0.19.2'): | ||
| raise ImportError("Pandas >= 0.19.2 must be installed on calling Python process") | ||
| raise ImportError("Pandas >= 0.19.2 must be installed on calling Python process: %s" |
Member
There was a problem hiding this comment.
Maybe, we could make it a bit better like .. .. on calling Python process; however, your version was %s..
Member
Author
There was a problem hiding this comment.
Sounds good. I'll update them. Thanks!
|
Test build #85366 has finished for PR 20074 at commit
|
|
Test build #85367 has finished for PR 20074 at commit
|
Member
Author
|
Thanks for reviewing! merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up pr of #20054 modifying error messages for both pandas and pyarrow to show actual versions.
How was this patch tested?
Existing tests.