Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Dec 23, 2017

What changes were proposed in this pull request?

We should use dataType.simpleString to unified the data type mismatch message:
Before:

spark-sql> select cast(1 as binary);
Error in query: cannot resolve 'CAST(1 AS BINARY)' due to data type mismatch: cannot cast IntegerType to BinaryType; line 1 pos 7;

After:

park-sql> select cast(1 as binary);
Error in query: cannot resolve 'CAST(1 AS BINARY)' due to data type mismatch: cannot cast int to binary; line 1 pos 7;

How was this patch tested?

Exist test.

@SparkQA
Copy link

SparkQA commented Dec 23, 2017

Test build #85339 has finished for PR 20064 at commit 8540b91.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 23, 2017

Test build #85341 has finished for PR 20064 at commit 1ee7315.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented Dec 23, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Dec 23, 2017

Test build #85343 has finished for PR 20064 at commit 1ee7315.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 23, 2017

Test build #85345 has finished for PR 20064 at commit f94e9f3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

Thanks! Merged to master.

@dongjoon-hyun
Copy link
Member

Hi, @gatorsmile and @wangyum .
This PR seems to break Jenkins tests. Please see my hotfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants