Skip to content

Conversation

@gerashegalov
Copy link
Contributor

What changes were proposed in this pull request?

Add tarLongFileMode=posix configuration for the assembly plugin

How was this patch tested?

Reran build successfully

./build/mvn package -Pbigtop-dist -DskipTests -rf :spark-assembly_2.11
[INFO] Spark Project Assembly ............................. SUCCESS [ 23.082 s]

@srowen
Copy link
Member

srowen commented Dec 22, 2017

Looks OK, but I believe this config needs to go in the parent pom.xml, where maven-assembly-plugin is configured for all uses. This is just changing one use of it for bigtop.

@srowen
Copy link
Member

srowen commented Dec 26, 2017

Ping @gerashegalov

@gerashegalov
Copy link
Contributor Author

agreed @srowen, this is a better fix although no other goal seemed affected. Thanks for suggestion!

@SparkQA
Copy link

SparkQA commented Dec 28, 2017

Test build #4025 has finished for PR 20055 at commit 6e37e9d.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 28, 2017

Merged to master

@asfgit asfgit closed this in 8f6d573 Dec 28, 2017
@gerashegalov
Copy link
Contributor Author

Thank you for review and commit @srowen

@gerashegalov gerashegalov deleted the gera/tarLongFileMode branch January 4, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants